feat: Add Extensions to Rokt Kit#26
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for vNext Extensions to the Rokt Kit by introducing new functions for generating launcher scripts and extracting extension data. The key changes include:
- Adding unit tests in test/src/tests.js for generating launcher scripts with various extension inputs.
- Implementing new functions (generateLauncherScript, parseSettingsString, extractvNextExtensions) to support vNext Extensions in src/Rokt-Kit.js.
- Integrating the extension data with the Rokt SDK via a new setExtensionData method.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/src/tests.js | Adds comprehensive unit tests for validating launcher script generation and extension extraction. |
| src/Rokt-Kit.js | Implements vNextExtensions support including parsing settings and generating launcher URLs. |
Comments suppressed due to low confidence (1)
src/Rokt-Kit.js:28
- [nitpick] The local variable 'roktLauncherScript' declared inside the constructor shadows the earlier module-level declaration; consider renaming it to clarify its scope and intended usage.
var roktLauncherScript = '';
alexs-mparticle
requested review from
BrandonStalnaker,
Mansi-mParticle,
crisryantan,
jklafka-rokt and
rmi22186
rmi22186
reviewed
Apr 24, 2025
rmi22186
reviewed
Apr 24, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for vNext Extensions to the Rokt Kit by introducing new helper functions and modifying the launcher script generation to correctly append extensions.
- Introduces a constant mapping (VNEXT_EXTENSIONS) for known extension names.
- Adds the generateLauncherScript helper to build URLs with extension query parameters.
- Implements functions to extract vNext extensions from settings and to set extension data, along with corresponding tests.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Rokt-Kit.js | Implements vNext Extension support, helper functions for URL generation and data mapping |
| test/src/tests.js | Adds tests for generateLauncherScript and extractvNextExtensions functions |
alexs-mparticle
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for vNext Extensions to the Rokt Kit, allowing users to configure extension data and generate a launcher script URL with query parameters based on a list of extensions. Key changes include:
- Introduction of a constant mapping (ROKT_EXTENSIONS) and helper functions (generateLauncherScript, extractRoktExtensions, and setExtensionData) in the kit.
- Enhancements in test coverage to validate URL generation and correct mapping of extension names.
- Modifications to the script insertion logic in attachLauncher to incorporate extension parameters.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/src/tests.js | Added tests for generateLauncherScript and extractRoktExtensions |
| src/Rokt-Kit.js | Implemented support for extensions, including new helper methods and integration in the launcher creation process |
rmi22186
approved these changes
Apr 30, 2025
rmi22186
left a comment
rmi22186
left a comment
Collaborator
There was a problem hiding this comment.
approving, but we need to confirm with ignacio/sarthi how long adding a new cusom json mapping would take still
jklafka-rokt
approved these changes
Apr 30, 2025
alexs-mparticle
force-pushed
the
feat/SQDSDKS-7233-vnext-extensions
branch
from
d379eaa to
c3d24d9
Compare
alexs-mparticle
force-pushed
the
feat/SQDSDKS-7233-vnext-extensions
branch
from
c3d24d9 to
1db3c91
Compare
rmi22186
approved these changes
Jul 11, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
# [1.6.0](v1.5.0...v1.6.0) (2025-07-14) ### Bug Fixes * Prevent mutation of global launcherOptions during initialization ([#36](#36)) ([0f36fac](0f36fac)) ### Features * Add Extensions to Rokt Kit ([#26](#26)) ([73e9696](73e9696)) * Support adding identities to select placement attributes ([#35](#35)) ([f9595ea](f9595ea))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
offer-container,cancel-buttonandconfirm-button.setExtensionDatausing the following in the dev console:https://apps.rokt.com/v1/eventswith:SignalPartnerImpressionSignalPartnerResponseSignalPartnerDismissal